Skip to content

drivers: spi: Add driver support for TI MSPM0 SPI module #94726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

drivers: spi: Add driver support for TI MSPM0 SPI module #94726

wants to merge 4 commits into from
+418 −1

Conversation

@santhosh-c-c
Copy link

@santhosh-c-c santhosh-c-c commented Aug 20, 2025

This is a draft PR for adding the driver support for TI MSPM0 SPI module.

There are few things left to fix.

Signed-off-by: Santhosh Charles [email protected]

@parthitce parthitce linked an issue Aug 20, 2025 that may be closed by this pull request
SPI linumiz/zephyr#73
Open
@santhosh-c-c santhosh-c-c force-pushed the upstream/ti/mspm0-spi branch 2 times, most recently from 59f786c to 6b7114b Compare August 26, 2025 13:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hansbinderup
Copy link
Contributor

hansbinderup commented Sep 4, 2025

I'd appreciate if I was added as co-author @santhosh-c-c :)
Most of the driver is based on the work I did a year ago msp-ti/zephyr@2b69efa (#5) msp-ti#5

tbursztyka
tbursztyka requested changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@tbursztyka tbursztyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use @hansbinderup's original commit as first, do not modify it.

Then add your modifications (ti,clk-div and few details) in further commits.

Also: do not add your copyright unless significant changes (like: adding interrupt mode support for instance).

dts/bindings/spi/ti,mspm0-spi.yaml Outdated
clocks:
required: true

clk-div:
Copy link
Contributor

@tbursztyka tbursztyka Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ti,clk-div

@santhosh-c-c
dts: bindings: spi: Add DT bindings for TI MSPM0 SPI module
dfefa15 
Add devicetree bindings for the TI MSPM0 SPI module.

Signed-off-by: Santhosh Charles <[email protected]>
Signed-off-by: Jackson Farley <[email protected]>
@santhosh-c-c santhosh-c-c force-pushed the upstream/ti/mspm0-spi branch from 6b7114b to fd737b8 Compare October 10, 2025 05:14
@santhosh-c-c
Copy link
Author

santhosh-c-c commented Oct 10, 2025

I'd appreciate if I was added as co-author @santhosh-c-c :) Most of the driver is based on the work I did a year ago msp-ti/zephyr@2b69efa (#5) msp-ti#5

Sure, I have added you as co-author.

@santhosh-c-c
Copy link
Author

santhosh-c-c commented Oct 10, 2025

Please, use @hansbinderup's original commit as first, do not modify it.

Then add your modifications (ti,clk-div and few details) in further commits.

Also: do not add your copyright unless significant changes (like: adding interrupt mode support for instance).

I understand your point. I believe using the downstream commit directly for upstreaming may not be ideal, but I have credited @hansbinderup as co-author. The driver has also undergone significant changes and further work based on our contributions.

santhosh-c-c and others added 3 commits October 30, 2025 16:02
@santhosh-c-c @hansbinderup
drivers: spi: Add driver support for TI MSPM0 SPI module
cc5ab0a 
Add support for the SPI module on TI’s MSPM0 MCUs.
The driver supports master mode transfers with configurable
frame size (4–16 bits), clock polarity/phase, bit order.

Signed-off-by: Santhosh Charles <[email protected]>
Signed-off-by: Jackson Farley <[email protected]>
Co-authored-by: Hans Binderup <[email protected]>
@santhosh-c-c
dts: arm: ti: mspm0: Add SPI nodes for TI MSPM0
bf4ebbb 
Add SPI nodes in TI MSPM0 family where the spi nodes are present.

Signed-off-by: Santhosh Charles <[email protected]>
Signed-off-by: Jackson Farley <[email protected]>
@santhosh-c-c
west: Update hal_ti to in flight PR
f8e1a52 
In flight PR includes the input-enable property for all
SPI POCI pins for mspm0l222x series.

Signed-off-by: Santhosh Charles <[email protected]>
@santhosh-c-c santhosh-c-c force-pushed the upstream/ti/mspm0-spi branch from fd737b8 to f8e1a52 Compare October 30, 2025 10:36
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_ti zephyrproject-rtos/hal_ti@391f7cb zephyrproject-rtos/hal_ti#73 zephyrproject-rtos/hal_ti#73/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_ti DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 30, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 30, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbursztyka tbursztyka tbursztyka requested changes

@ssekar15 ssekar15 Awaiting requested review from ssekar15

Requested changes must be addressed to merge this pull request.

Assignees

@ssekar15 ssekar15

Labels

DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_ti platform: Texas Instruments MSPM0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SPI

5 participants

@santhosh-c-c @hansbinderup @tbursztyka @parthitce @ssekar15